tools: Correct PTHREAD options in config/StdGNU.mk
authorIan Jackson <ian.jackson@eu.citrix.com>
Wed, 11 Apr 2012 13:14:11 +0000 (14:14 +0100)
committerIan Jackson <ian.jackson@eu.citrix.com>
Wed, 11 Apr 2012 13:14:11 +0000 (14:14 +0100)
commit90b969c2ede4bd5ba3722d0f2a71a77d8380bf80
treed80784684a262b3dd427ba9895780af6cc8f19b5
parent862bf6424b9cd460b337cb5e47f16d3581970ff2
tools: Correct PTHREAD options in config/StdGNU.mk

It is not correct to say -lpthread.  The correct option is -pthread,
which may have sundry other effects on code generation etc.  It needs
to be passed both to compilation and linking.

Fix the configure test to test -pthread, and plumb the resulting flag
through to PTHREAD_{CFLAGS,LDFLAGS} in Tools.mk; also substitute
PTHREAD_LIBS (although this will currently always be empty).
Remove PTHREAD_LIBS setting from StdGNU.mk.

Fix the one user (libxc) to use PTHREAD_{CFLAGS,LDFLAGS} too.

There are still some other users in tree which pass -pthread or
-lpthread by adding it as a literal to their own compiler options.
These will be fixed in a later patch.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@entel.upc.edu>
Acked-by: Roger Pau Monne <roger.pau@entel.upc.edu>
Committed-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
config/StdGNU.mk
config/Tools.mk.in
tools/configure
tools/configure.ac
tools/libxc/Makefile
tools/m4/pthread.m4 [new file with mode: 0644]
tools/m4/savevar.m4 [new file with mode: 0644]